Add SharedString defaults to reflection database #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dekkonot
approved these changes
Oct 23, 2024
Member
Author
|
Whoops, looks like some |
Member
|
And after my approval too. 😔 This looks like it's just a consequence of adding defaults. Since they're present, we no longer generate an empty one for SharedString properties. This changes the index of other strings in the file though, since one is no longer present. |
kennethloeffler
commented
Oct 23, 2024
Dekkonot
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #414,
SharedStringvalues are now representable in serde formats, meaning that it's now possible for the reflection database to define defaults forSharedStringproperties. This will be useful for Rojo's syncback, whenSharedStringproperties need to be written to JSON files: UpliftGames/rojo#6 (comment).